Commit f49aa960a9

Jakub Konka <kubkon@jakubkonka.com>
2021-08-04 10:47:11
macho: use ArrayHashMap.popOrNull where applicable
1 parent f01366e
Changed files (1)
src
src/link/MachO.zig
@@ -2329,11 +2329,8 @@ fn resolveSymbols(self: *MachO) !void {
 
     // Convert any tentative definition into a regular symbol and allocate
     // text blocks for each tentative defintion.
-    var tentatives_count: usize = 0;
-    const ntentatives = tentatives.count();
-    while (tentatives_count < ntentatives) : (tentatives_count += 1) {
-        const index = tentatives.pop().key;
-        const sym = &self.globals.items[index];
+    while (tentatives.popOrNull()) |entry| {
+        const sym = &self.globals.items[entry.key];
         const match: MatchingSection = blk: {
             if (self.common_section_index == null) {
                 const data_seg = &self.load_commands.items[self.data_segment_cmd_index.?].Segment;