Commit f1b6f1aeb3

Sean <69403556+SeanTheGleaming@users.noreply.github.com>
2024-06-23 05:33:45
std.meta.hasUniqueRepresentation: Handle optional pointers correctly (#20366)
std.meta.hasUniqueRepresentation should now return true for non-slice optional pointers. Additional checks were added to the test to reflect this.
master
1 parent 642093e
Changed files (1)
lib
std
meta.zig
lib/std/meta.zig
@@ -1203,6 +1203,14 @@ pub inline fn hasUniqueRepresentation(comptime T: type) bool {
 
         .Pointer => |info| info.size != .Slice,
 
+        .Optional => |info| switch (@typeInfo(info.child)) {
+            .Pointer => |ptr| !ptr.is_allowzero and switch (ptr.size) {
+                .Slice, .C => false,
+                .One, .Many => true,
+            },
+            else => false,
+        },
+
         .Array => |info| hasUniqueRepresentation(info.child),
 
         .Struct => |info| {
@@ -1301,8 +1309,15 @@ test hasUniqueRepresentation {
         try testing.expect(!hasUniqueRepresentation(T));
     }
 
+    try testing.expect(hasUniqueRepresentation(*u8));
+    try testing.expect(hasUniqueRepresentation(*const u8));
+    try testing.expect(hasUniqueRepresentation(?*u8));
+    try testing.expect(hasUniqueRepresentation(?*const u8));
+
     try testing.expect(!hasUniqueRepresentation([]u8));
     try testing.expect(!hasUniqueRepresentation([]const u8));
+    try testing.expect(!hasUniqueRepresentation(?[]u8));
+    try testing.expect(!hasUniqueRepresentation(?[]const u8));
 
     try testing.expect(hasUniqueRepresentation(@Vector(std.simd.suggestVectorLength(u8) orelse 1, u8)));
     try testing.expect(@sizeOf(@Vector(3, u8)) == 3 or !hasUniqueRepresentation(@Vector(3, u8)));