Commit e675af0698

Jakub Konka <kubkon@jakubkonka.com>
2023-01-24 17:31:13
elf+macho: append null to DWARF strtab to avoid overlapping sects
Otherwise, we were risking having strtab zero-sized and overlap with another section.
master
1 parent d703270
Changed files (2)
src
link
MachO
DebugSymbols.zig
Elf.zig
src/link/MachO/DebugSymbols.zig
@@ -83,6 +83,7 @@ pub fn populateMissingMetadata(self: *DebugSymbols) !void {
 
     if (self.debug_str_section_index == null) {
         assert(self.dwarf.strtab.items.len == 0);
+        try self.dwarf.strtab.append(self.allocator, 0);
         self.debug_str_section_index = try self.allocateSection(
             "__debug_str",
             @intCast(u32, self.dwarf.strtab.items.len),
src/link/Elf.zig
@@ -756,10 +756,11 @@ pub fn populateMissingMetadata(self: *Elf) !void {
         try self.writeSymbol(0);
     }
 
-    if (self.dwarf) |dw| {
+    if (self.dwarf) |*dw| {
         if (self.debug_str_section_index == null) {
             self.debug_str_section_index = @intCast(u16, self.sections.items.len);
             assert(dw.strtab.items.len == 0);
+            try dw.strtab.append(self.base.allocator, 0);
             try self.sections.append(self.base.allocator, .{
                 .sh_name = try self.makeString(".debug_str"),
                 .sh_type = elf.SHT_PROGBITS,