Commit e444e69dc4

Jakub Konka <kubkon@jakubkonka.com>
2022-03-25 17:31:22
dwarf: do not use `Type.errorSetNames()` for inferred error sets
Otherwise, we risk tripping an assertion in `Type.errorSetNames()` in case the inferred error set was not yet fully resolved. This so far only surfaced when Dwarf triggers recursive analysis of an error set as part of emitting debug info for an error union.
master
1 parent 4985abc
Changed files (1)
src
link
Dwarf.zig
src/link/Dwarf.zig
@@ -1117,7 +1117,18 @@ fn addDbgInfoType(
             // DW.AT.const_value, DW.FORM.data8
             mem.writeInt(u64, dbg_info_buffer.addManyAsArrayAssumeCapacity(8), 0, target_endian);
 
-            const error_names = if (ty.isAnyError()) module.error_name_list.items else ty.errorSetNames();
+            const error_names = blk: {
+                if (ty.isAnyError())
+                    break :blk module.error_name_list.items;
+                // TODO not quite sure about the next one, but if I don't do this, I risk
+                // tripping an assert in `Type.errorSetNames` in case the inferred error set
+                // was not yet fully resolved. This so far only surfaced when this code would
+                // schedule analysis of an error set part of some error union.
+                if (ty.tag() == .error_set_inferred)
+                    break :blk ty.castTag(.error_set_inferred).?.data.errors.keys();
+                break :blk ty.errorSetNames();
+            };
+
             for (error_names) |error_name| {
                 const kv = module.getErrorValue(error_name) catch unreachable;
                 // DW.AT.enumerator