Commit `dd4e9fb16b`

Sebastian Keller <sebastiankeller@fastmail.net>

2019-11-06 01:42:07

Fixed a leak in the json parser.

parseString() created a copy of the string using the wrong allocator. Instead of using the ArenaAllocator, it was using the allocator passed into Parser.init(). This lead to a leak as the copied string was not freed when the ArenaAllocator was deinited.

master

1 parent 6b61fcd

Changed files (1)

lib

std

json.zig

@@ -898,7 +898,7 @@ pub const TokenStream = struct {
             }
         }
 
-        if(self.parser.complete){
+        if (self.parser.complete) {
             return null;
         } else {
             return error.UnexpectedEndOfJson;
@@ -1339,7 +1339,7 @@ pub const Parser = struct {
         // TODO: We don't strictly have to copy values which do not contain any escape
         // characters if flagged with the option.
         const slice = token.slice(input, i);
-        return Value{ .String = try mem.dupe(p.allocator, u8, slice) };
+        return Value{ .String = try mem.dupe(allocator, u8, slice) };
     }
 
     fn parseNumber(p: *Parser, token: Token, input: []const u8, i: usize) !Value {

Commit dd4e9fb16b

Commit `dd4e9fb16b`