Commit d4ca9804f8

Alex Rønne Petersen <alex@alexrp.com>
2024-11-02 08:59:14
riscv64: Handle writes to the zero register sensibly in result bookkeeping.
master
1 parent 61ae9a2
Changed files (1)
src
arch
riscv64
CodeGen.zig
src/arch/riscv64/CodeGen.zig
@@ -1769,8 +1769,15 @@ fn finishAirBookkeeping(func: *Func) void {
 fn finishAirResult(func: *Func, inst: Air.Inst.Index, result: MCValue) void {
     if (func.liveness.isUnused(inst)) switch (result) {
         .none, .dead, .unreach => {},
-        else => unreachable, // Why didn't the result die?
+        // Why didn't the result die?
+        .register => |r| if (r != .zero) unreachable,
+        else => unreachable,
     } else {
+        switch (result) {
+            .register => |r| if (r == .zero) unreachable, // Why did we discard a used result?
+            else => {},
+        }
+
         tracking_log.debug("%{d} => {} (birth)", .{ inst, result });
         func.inst_tracking.putAssumeCapacityNoClobber(inst, InstTracking.init(result));
         // In some cases, an operand may be reused as the result.