Commit d227f76afb

Andrew Kelley <andrew@ziglang.org>
2022-03-30 20:52:10
std.zig.Ast: fix escaped capture of by-value parameters
master
1 parent 47dfaf4
Changed files (2)
lib
std
zig
Ast.zig
src
AstGen.zig
lib/std/zig/Ast.zig
@@ -2354,10 +2354,10 @@ pub const full = struct {
             }
         };
 
-        pub fn iterate(fn_proto: FnProto, tree: Ast) Iterator {
+        pub fn iterate(fn_proto: *const FnProto, tree: *const Ast) Iterator {
             return .{
-                .tree = &tree,
-                .fn_proto = &fn_proto,
+                .tree = tree,
+                .fn_proto = fn_proto,
                 .param_i = 0,
                 .tok_i = fn_proto.lparen + 1,
                 .tok_flag = true,
src/AstGen.zig
@@ -1122,7 +1122,7 @@ fn fnProtoExpr(
 
     const is_var_args = is_var_args: {
         var param_type_i: usize = 0;
-        var it = fn_proto.iterate(tree.*);
+        var it = fn_proto.iterate(tree);
         while (it.next()) |param| : (param_type_i += 1) {
             const is_comptime = if (param.comptime_noalias) |token|
                 token_tags[token] == .keyword_comptime
@@ -3377,7 +3377,7 @@ fn fnDecl(
     var params_scope = &fn_gz.base;
     const is_var_args = is_var_args: {
         var param_type_i: usize = 0;
-        var it = fn_proto.iterate(tree.*);
+        var it = fn_proto.iterate(tree);
         while (it.next()) |param| : (param_type_i += 1) {
             const is_comptime = if (param.comptime_noalias) |token|
                 token_tags[token] == .keyword_comptime