Commit `c6986f29f9`

Zander Khan <git@zander.xyz>

2021-01-16 19:11:26

Fix update might change an element no longer in the queue

master

1 parent 4600b48

Changed files (2)

lib

std

priority_dequeue.zig

priority_queue.zig

@@ -389,7 +389,7 @@ pub fn PriorityDequeue(comptime T: type) type {
         }
 
         pub fn update(self: *Self, elem: T, new_elem: T) !void {
-            var old_index: usize = std.mem.indexOfScalar(T, self.items, elem) orelse return error.ElementNotFound;
+            var old_index: usize = std.mem.indexOfScalar(T, self.items[0 .. self.len - 1], elem) orelse return error.ElementNotFound;
             _ = self.removeIndex(old_index);
             self.addUnchecked(new_elem);
         }

@@ -199,7 +199,7 @@ pub fn PriorityQueue(comptime T: type) type {
         }
 
         pub fn update(self: *Self, elem: T, new_elem: T) !void {
-            var update_index: usize = std.mem.indexOfScalar(T, self.items, elem) orelse return error.ElementNotFound;
+            var update_index: usize = std.mem.indexOfScalar(T, self.items[0 .. self.len - 1], elem) orelse return error.ElementNotFound;
             const old_elem: T = self.items[update_index];
             self.items[update_index] = new_elem;
             if (self.compareFn(new_elem, old_elem)) {

Commit c6986f29f9

Commit `c6986f29f9`