Commit `bd9c629c4c`

Andrew Kelley <andrew@ziglang.org>

2019-05-03 20:39:54

always respect threadlocal for variables with external linkage

Previously if you had, for example: extern "c" threadlocal var errno: c_int; This would turn errno into a normal variable for --single-threaded builds. However for variables with external linkage, there is an ABI to uphold. This is needed to make errno work for DragonFly BSD. See #2381.

master

1 parent 8cda4fd

Changed files (1)

src

codegen.cpp

@@ -6639,7 +6639,7 @@ static void validate_inline_fns(CodeGen *g) {
 }
 
 static void set_global_tls(CodeGen *g, ZigVar *var, LLVMValueRef global_value) {
-    if (var->is_thread_local && !g->is_single_threaded) {
+    if (var->is_thread_local && (!g->is_single_threaded || var->linkage != VarLinkageInternal)) {
         LLVMSetThreadLocalMode(global_value, LLVMGeneralDynamicTLSModel);
     }
 }

Commit bd9c629c4c

Commit `bd9c629c4c`