Commit bd1f96869e

Andrew Kelley <andrew@ziglang.org>
2023-10-19 23:17:03
InternPool: fix incomplete hash of pointer values
There is this `common` prefix which was not getting passed in all union tags of pointer vals, resumably making InternPool slower for pointer values.
master
1 parent 328ec15
Changed files (1)
src
InternPool.zig
src/InternPool.zig
@@ -1228,7 +1228,7 @@ pub const Key = union(enum) {
 
                     .mut_decl => |x| Hash.hash(
                         seed2,
-                        asBytes(&x.decl) ++ asBytes(&x.runtime_index),
+                        common ++ asBytes(&x.decl) ++ asBytes(&x.runtime_index),
                     ),
 
                     .anon_decl,
@@ -1236,11 +1236,11 @@ pub const Key = union(enum) {
                     .eu_payload,
                     .opt_payload,
                     .comptime_field,
-                    => |int| Hash.hash(seed2, asBytes(&int)),
+                    => |int| Hash.hash(seed2, common ++ asBytes(&int)),
 
                     .elem, .field => |x| Hash.hash(
                         seed2,
-                        asBytes(&x.base) ++ asBytes(&x.index),
+                        common ++ asBytes(&x.base) ++ asBytes(&x.index),
                     ),
                 };
             },