Commit b6f84c47c4

Andrew Kelley <andrew@ziglang.org>
2025-08-05 08:57:51
std.base64: delete encodeFromReaderToWriter
this function is wacky, should not have been merged
1 parent 196e36b
Changed files (1)
lib
lib/std/base64.zig
@@ -118,22 +118,6 @@ pub const Base64Encoder = struct {
         }
     }
 
-    // destWriter must be compatible with std.io.GenericWriter's writeAll interface
-    // sourceReader must be compatible with `std.io.GenericReader` read interface
-    pub fn encodeFromReaderToWriter(encoder: *const Base64Encoder, destWriter: anytype, sourceReader: anytype) !void {
-        while (true) {
-            var tempSource: [3]u8 = undefined;
-            const bytesRead = try sourceReader.read(&tempSource);
-            if (bytesRead == 0) {
-                break;
-            }
-
-            var temp: [5]u8 = undefined;
-            const s = encoder.encode(&temp, tempSource[0..bytesRead]);
-            try destWriter.writeAll(s);
-        }
-    }
-
     /// dest.len must at least be what you get from ::calcSize.
     pub fn encode(encoder: *const Base64Encoder, dest: []u8, source: []const u8) []const u8 {
         const out_len = encoder.calcSize(source.len);
@@ -525,14 +509,6 @@ fn testAllApis(codecs: Codecs, expected_decoded: []const u8, expected_encoded: [
         try codecs.Encoder.encodeWriter(&writer, expected_decoded);
         try testing.expectEqualSlices(u8, expected_encoded, writer.buffered());
     }
-    {
-        // reader to writer encode
-        var stream: std.Io.Reader = .fixed(expected_decoded);
-        var buffer: [0x100]u8 = undefined;
-        var writer: std.Io.Writer = .fixed(&buffer);
-        try codecs.Encoder.encodeFromReaderToWriter(&writer, &stream);
-        try testing.expectEqualSlices(u8, expected_encoded, writer.buffered());
-    }
 
     // Base64Decoder
     {