Commit `b196dd1d79`

Isaac Freund <mail@isaacfreund.com>

2021-11-26 19:33:42

std.system: fix slice bounds in preadMin()

If a partial read occurs past the halfway point, buf.len - i will be less than i, which is illegal. The end bound is also entirely unecessary in this case, so just remove it.

master

1 parent 7c2cc45

Changed files (1)

lib

std

zig

system.zig

@@ -922,7 +922,7 @@ pub const NativeTargetInfo = struct {
     fn preadMin(file: fs.File, buf: []u8, offset: u64, min_read_len: usize) !usize {
         var i: usize = 0;
         while (i < min_read_len) {
-            const len = file.pread(buf[i .. buf.len - i], offset + i) catch |err| switch (err) {
+            const len = file.pread(buf[i..], offset + i) catch |err| switch (err) {
                 error.OperationAborted => unreachable, // Windows-only
                 error.WouldBlock => unreachable, // Did not request blocking mode
                 error.NotOpenForReading => unreachable,

Commit b196dd1d79

Commit `b196dd1d79`