Commit ad6e095ef6

Timon Kruiper <timonkruiper@gmail.com>
2020-10-27 16:43:27
stage2.Elf: fix off by one error in writeOffsetTableEntry
The code was using the length of the local symbols, which also includes the null symbol. Fix this by using the offset table instead, which only keeps track of the symbols that end up in the got.
master
1 parent 4fb896f
Changed files (1)
src
link
Elf.zig
src/link/Elf.zig
@@ -2706,7 +2706,7 @@ fn writeOffsetTableEntry(self: *Elf, index: usize) !void {
     if (self.offset_table_count_dirty) {
         // TODO Also detect virtual address collisions.
         const allocated_size = self.allocatedSize(shdr.sh_offset);
-        const needed_size = self.local_symbols.items.len * entry_size;
+        const needed_size = self.offset_table.items.len * entry_size;
         if (needed_size > allocated_size) {
             // Must move the entire got section.
             const new_offset = self.findFreeSpace(needed_size, entry_size);