Commit a1d532752f

Frank Denis <124872+jedisct1@users.noreply.github.com>
2021-08-24 02:06:02
Don't define valgrind_support on macOS (#9612)
Unfortunately, Valgrind for macOS has been broken for years, and the Homebrew formula is only for Linux.
1 parent 2588451
Changed files (2)
src
stage1
target.cpp
target.zig
src/stage1/target.cpp
@@ -914,7 +914,7 @@ bool target_has_valgrind_support(const ZigTarget *target) {
         case ZigLLVM_UnknownArch:
             zig_unreachable();
         case ZigLLVM_x86_64:
-            return (target->os == OsLinux || target_os_is_darwin(target->os) || target->os == OsSolaris ||
+            return (target->os == OsLinux || target->os == OsSolaris ||
                 (target->os == OsWindows && target->abi != ZigLLVM_MSVC));
         default:
             return false;
src/target.zig
@@ -163,7 +163,7 @@ pub fn isSingleThreaded(target: std.Target) bool {
 pub fn hasValgrindSupport(target: std.Target) bool {
     switch (target.cpu.arch) {
         .x86_64 => {
-            return target.os.tag == .linux or target.isDarwin() or target.os.tag == .solaris or
+            return target.os.tag == .linux or target.os.tag == .solaris or
                 (target.os.tag == .windows and target.abi != .msvc);
         },
         else => return false,