Commit 995c36dcb1

Andrew Kelley <andrew@ziglang.org>
2023-01-02 22:09:01
avoid testing `inline for` in unrelated behavior tests
1 parent 72560b8
Changed files (2)
test
test/behavior/asm.zig
@@ -23,7 +23,7 @@ test "module level assembly" {
     if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
-    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO WIP
+    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
 
     if (is_x86_64_linux) {
         try expect(this_is_my_alias() == 1234);
@@ -36,7 +36,7 @@ test "output constraint modifiers" {
     if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
-    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO WIP
+    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
 
     // This is only testing compilation.
     var a: u32 = 3;
@@ -58,7 +58,7 @@ test "alternative constraints" {
     if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
-    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO WIP
+    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
 
     // Make sure we allow commas as a separator for alternative constraints.
     var a: u32 = 3;
@@ -75,7 +75,7 @@ test "sized integer/float in asm input" {
     if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
-    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO WIP
+    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
 
     asm volatile (""
         :
@@ -125,7 +125,7 @@ test "struct/array/union types as input values" {
     if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
-    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO WIP
+    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
 
     asm volatile (""
         :
test/behavior/atomics.zig
@@ -250,11 +250,18 @@ test "atomicrmw with ints" {
         return error.SkipZigTest;
     }
 
+    try testAtomicRmwInts();
+    comptime try testAtomicRmwInts();
+}
+
+fn testAtomicRmwInts() !void {
     // TODO: Use the max atomic bit size for the target, maybe builtin?
-    const bit_values = [_]usize{8} ++ if (builtin.cpu.arch == .x86_64) [_]usize{ 16, 32, 64 } else [_]usize{};
-    inline for (bit_values) |bits| {
-        try testAtomicRmwInt(.unsigned, bits);
-        comptime try testAtomicRmwInt(.unsigned, bits);
+    try testAtomicRmwInt(8);
+
+    if (builtin.cpu.arch == .x86_64) {
+        try testAtomicRmwInt(16);
+        try testAtomicRmwInt(32);
+        try testAtomicRmwInt(64);
     }
 }