Commit `9257669cd4`

Andrew Kelley <andrew@ziglang.org>

2021-12-16 11:33:37

glibc: do not pass -DSHARED to any of the libc_nonshared.a sources

This essentially reverts 6a12dce207114842e2e49a3aeb18af01ab207f0b but it leaves breadcrumbs in the source explaining why things are the way they are.

master

1 parent 1b0be5c

Changed files (1)

src

glibc.zig

@@ -335,8 +335,11 @@ pub fn buildCRTFile(comp: *Compilation, crt_file: CRTFile) !void {
                 }
 
                 const shared_def = switch (dep.flavor) {
-                    .shared => "-DSHARED",
                     .nonshared => "-DLIBC_NONSHARED=1",
+                    // glibc passes `-DSHARED` for these. However, empirically if
+                    // we do that here we will see undefined symbols such as `__GI_memcpy`.
+                    // So we pass the same thing as for nonshared.
+                    .shared => "-DLIBC_NONSHARED=1",
                 };
                 try args.appendSlice(&[_][]const u8{
                     "-D_LIBC_REENTRANT",

Commit 9257669cd4

Commit `9257669cd4`