Commit 919a3bae1c

Jacob Young <jacobly0@users.noreply.github.com>
2024-02-08 00:29:53
http: protect against zero-length chunks
A zero-length chunk marks the end of the body, so prevent any from possibly occurring in the middle of the body.
master
1 parent 3122fd0
Changed files (1)
lib
std
http
Client.zig
lib/std/http/Client.zig
@@ -1018,9 +1018,11 @@ pub const Request = struct {
     pub fn write(req: *Request, bytes: []const u8) WriteError!usize {
         switch (req.transfer_encoding) {
             .chunked => {
-                try req.connection.?.writer().print("{x}\r\n", .{bytes.len});
-                try req.connection.?.writer().writeAll(bytes);
-                try req.connection.?.writer().writeAll("\r\n");
+                if (bytes.len > 0) {
+                    try req.connection.?.writer().print("{x}\r\n", .{bytes.len});
+                    try req.connection.?.writer().writeAll(bytes);
+                    try req.connection.?.writer().writeAll("\r\n");
+                }
 
                 return bytes.len;
             },