Commit 89942ebd03

Lucas Santos <117400842+LucasSantos91@users.noreply.github.com>
2024-07-15 19:49:51
Better implementation of GetLastError. (#20623)
Instead of calling the dynamically loaded kernel32.GetLastError, we can extract it from the TEB. As shown by [Wine](https://github.com/wine-mirror/wine/blob/34b1606019982b71818780bc84b76460f650af31/include/winternl.h#L439), the last error lives at offset 0x34 of the TEB in 32-bit Windows and at offset 0x68 in 64-bit Windows.
1 parent cf36d3f
Changed files (9)
lib/std/crypto/Certificate/Bundle.zig
@@ -132,7 +132,7 @@ fn rescanWindows(cb: *Bundle, gpa: Allocator) RescanWindowsError!void {
     cb.map.clearRetainingCapacity();
 
     const w = std.os.windows;
-    const GetLastError = w.kernel32.GetLastError;
+    const GetLastError = w.GetLastError;
     const root = [4:0]u16{ 'R', 'O', 'O', 'T' };
     const store = w.crypt32.CertOpenSystemStoreW(null, &root) orelse switch (GetLastError()) {
         .FILE_NOT_FOUND => return error.FileNotFound,
lib/std/os/windows.zig
@@ -172,6 +172,10 @@ pub fn GetCurrentThreadId() DWORD {
     return @truncate(@intFromPtr(teb().ClientId.UniqueThread));
 }
 
+pub fn GetLastError() Win32Error {
+    return @enumFromInt(teb().LastErrorValue);
+}
+
 pub const CreatePipeError = error{ Unexpected, SystemResources };
 
 var npfs: ?HANDLE = null;
@@ -309,7 +313,7 @@ pub fn CreateEventExW(attributes: ?*SECURITY_ATTRIBUTES, nameW: ?LPCWSTR, flags:
     if (handle) |h| {
         return h;
     } else {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -385,7 +389,7 @@ pub fn DeviceIoControl(
 pub fn GetOverlappedResult(h: HANDLE, overlapped: *OVERLAPPED, wait: bool) !DWORD {
     var bytes: DWORD = undefined;
     if (kernel32.GetOverlappedResult(h, overlapped, &bytes, @intFromBool(wait)) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .IO_INCOMPLETE => if (!wait) return error.WouldBlock else unreachable,
             else => |err| return unexpectedError(err),
         }
@@ -397,7 +401,7 @@ pub const SetHandleInformationError = error{Unexpected};
 
 pub fn SetHandleInformation(h: HANDLE, mask: DWORD, flags: DWORD) SetHandleInformationError!void {
     if (kernel32.SetHandleInformation(h, mask, flags) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -417,7 +421,7 @@ pub fn RtlGenRandom(output: []u8) RtlGenRandomError!void {
         const to_read: ULONG = @min(buff.len, max_read_size);
 
         if (advapi32.RtlGenRandom(buff.ptr, to_read) == 0) {
-            return unexpectedError(kernel32.GetLastError());
+            return unexpectedError(GetLastError());
         }
 
         total_read += to_read;
@@ -440,7 +444,7 @@ pub fn WaitForSingleObjectEx(handle: HANDLE, milliseconds: DWORD, alertable: boo
         WAIT_ABANDONED => return error.WaitAbandoned,
         WAIT_OBJECT_0 => return,
         WAIT_TIMEOUT => return error.WaitTimeOut,
-        WAIT_FAILED => switch (kernel32.GetLastError()) {
+        WAIT_FAILED => switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         },
         else => return error.Unexpected,
@@ -468,7 +472,7 @@ pub fn WaitForMultipleObjectsEx(handles: []const HANDLE, waitAll: bool, millisec
             return error.WaitAbandoned;
         },
         WAIT_TIMEOUT => return error.WaitTimeOut,
-        WAIT_FAILED => switch (kernel32.GetLastError()) {
+        WAIT_FAILED => switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         },
         else => return error.Unexpected,
@@ -484,7 +488,7 @@ pub fn CreateIoCompletionPort(
     concurrent_thread_count: DWORD,
 ) CreateIoCompletionPortError!HANDLE {
     const handle = kernel32.CreateIoCompletionPort(file_handle, existing_completion_port, completion_key, concurrent_thread_count) orelse {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .INVALID_PARAMETER => unreachable,
             else => |err| return unexpectedError(err),
         }
@@ -501,7 +505,7 @@ pub fn PostQueuedCompletionStatus(
     lpOverlapped: ?*OVERLAPPED,
 ) PostQueuedCompletionStatusError!void {
     if (kernel32.PostQueuedCompletionStatus(completion_port, bytes_transferred_count, completion_key, lpOverlapped) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -528,7 +532,7 @@ pub fn GetQueuedCompletionStatus(
         lpOverlapped,
         dwMilliseconds,
     ) == FALSE) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .ABANDONED_WAIT_0 => return GetQueuedCompletionStatusResult.Aborted,
             .OPERATION_ABORTED => return GetQueuedCompletionStatusResult.Cancelled,
             .HANDLE_EOF => return GetQueuedCompletionStatusResult.EOF,
@@ -568,7 +572,7 @@ pub fn GetQueuedCompletionStatusEx(
     );
 
     if (success == FALSE) {
-        return switch (kernel32.GetLastError()) {
+        return switch (GetLastError()) {
             .ABANDONED_WAIT_0 => error.Aborted,
             .OPERATION_ABORTED => error.Cancelled,
             .HANDLE_EOF => error.EOF,
@@ -618,7 +622,7 @@ pub fn ReadFile(in_hFile: HANDLE, buffer: []u8, offset: ?u64) ReadFileError!usiz
             break :blk &overlapped_data;
         } else null;
         if (kernel32.ReadFile(in_hFile, buffer.ptr, want_read_count, &amt_read, overlapped) == 0) {
-            switch (kernel32.GetLastError()) {
+            switch (GetLastError()) {
                 .IO_PENDING => unreachable,
                 .OPERATION_ABORTED => continue,
                 .BROKEN_PIPE => return 0,
@@ -667,7 +671,7 @@ pub fn WriteFile(
     } else null;
     const adjusted_len = math.cast(u32, bytes.len) orelse maxInt(u32);
     if (kernel32.WriteFile(handle, bytes.ptr, adjusted_len, &bytes_written, overlapped) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .INVALID_USER_BUFFER => return error.SystemResources,
             .NOT_ENOUGH_MEMORY => return error.SystemResources,
             .OPERATION_ABORTED => return error.OperationAborted,
@@ -728,7 +732,7 @@ pub fn GetCurrentDirectory(buffer: []u8) GetCurrentDirectoryError![]u8 {
     var wtf16le_buf: [PATH_MAX_WIDE]u16 = undefined;
     const result = kernel32.GetCurrentDirectoryW(wtf16le_buf.len, &wtf16le_buf);
     if (result == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -1109,7 +1113,7 @@ pub fn MoveFileEx(old_path: []const u8, new_path: []const u8, flags: DWORD) Move
 
 pub fn MoveFileExW(old_path: [*:0]const u16, new_path: [*:0]const u16, flags: DWORD) MoveFileError!void {
     if (kernel32.MoveFileExW(old_path, new_path, flags) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .FILE_NOT_FOUND => return error.FileNotFound,
             .ACCESS_DENIED => return error.AccessDenied,
             else => |err| return unexpectedError(err),
@@ -1125,7 +1129,7 @@ pub const GetStdHandleError = error{
 pub fn GetStdHandle(handle_id: DWORD) GetStdHandleError!HANDLE {
     const handle = kernel32.GetStdHandle(handle_id) orelse return error.NoStandardHandleAttached;
     if (handle == INVALID_HANDLE_VALUE) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -1141,7 +1145,7 @@ pub fn SetFilePointerEx_BEGIN(handle: HANDLE, offset: u64) SetFilePointerError!v
     // https://docs.microsoft.com/en-us/windows/desktop/api/fileapi/nf-fileapi-setfilepointerex
     const ipos = @as(LARGE_INTEGER, @bitCast(offset));
     if (kernel32.SetFilePointerEx(handle, ipos, null, FILE_BEGIN) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .INVALID_PARAMETER => unreachable,
             .INVALID_HANDLE => unreachable,
             else => |err| return unexpectedError(err),
@@ -1152,7 +1156,7 @@ pub fn SetFilePointerEx_BEGIN(handle: HANDLE, offset: u64) SetFilePointerError!v
 /// The SetFilePointerEx function with the `dwMoveMethod` parameter set to `FILE_CURRENT`.
 pub fn SetFilePointerEx_CURRENT(handle: HANDLE, offset: i64) SetFilePointerError!void {
     if (kernel32.SetFilePointerEx(handle, offset, null, FILE_CURRENT) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .INVALID_PARAMETER => unreachable,
             .INVALID_HANDLE => unreachable,
             else => |err| return unexpectedError(err),
@@ -1163,7 +1167,7 @@ pub fn SetFilePointerEx_CURRENT(handle: HANDLE, offset: i64) SetFilePointerError
 /// The SetFilePointerEx function with the `dwMoveMethod` parameter set to `FILE_END`.
 pub fn SetFilePointerEx_END(handle: HANDLE, offset: i64) SetFilePointerError!void {
     if (kernel32.SetFilePointerEx(handle, offset, null, FILE_END) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .INVALID_PARAMETER => unreachable,
             .INVALID_HANDLE => unreachable,
             else => |err| return unexpectedError(err),
@@ -1175,7 +1179,7 @@ pub fn SetFilePointerEx_END(handle: HANDLE, offset: i64) SetFilePointerError!voi
 pub fn SetFilePointerEx_CURRENT_get(handle: HANDLE) SetFilePointerError!u64 {
     var result: LARGE_INTEGER = undefined;
     if (kernel32.SetFilePointerEx(handle, 0, &result, FILE_CURRENT) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .INVALID_PARAMETER => unreachable,
             .INVALID_HANDLE => unreachable,
             else => |err| return unexpectedError(err),
@@ -1489,7 +1493,7 @@ pub const GetFileSizeError = error{Unexpected};
 pub fn GetFileSizeEx(hFile: HANDLE) GetFileSizeError!u64 {
     var file_size: LARGE_INTEGER = undefined;
     if (kernel32.GetFileSizeEx(hFile, &file_size) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -1510,7 +1514,7 @@ pub fn GetFileAttributes(filename: []const u8) GetFileAttributesError!DWORD {
 pub fn GetFileAttributesW(lpFileName: [*:0]const u16) GetFileAttributesError!DWORD {
     const rc = kernel32.GetFileAttributesW(lpFileName);
     if (rc == INVALID_FILE_ATTRIBUTES) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .FILE_NOT_FOUND => return error.FileNotFound,
             .PATH_NOT_FOUND => return error.FileNotFound,
             .ACCESS_DENIED => return error.PermissionDenied,
@@ -1721,7 +1725,7 @@ const GetModuleFileNameError = error{Unexpected};
 pub fn GetModuleFileNameW(hModule: ?HMODULE, buf_ptr: [*]u16, buf_len: DWORD) GetModuleFileNameError![:0]u16 {
     const rc = kernel32.GetModuleFileNameW(hModule, buf_ptr, buf_len);
     if (rc == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -1732,7 +1736,7 @@ pub const TerminateProcessError = error{ PermissionDenied, Unexpected };
 
 pub fn TerminateProcess(hProcess: HANDLE, uExitCode: UINT) TerminateProcessError!void {
     if (kernel32.TerminateProcess(hProcess, uExitCode) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             Win32Error.ACCESS_DENIED => return error.PermissionDenied,
             else => |err| return unexpectedError(err),
         }
@@ -1743,7 +1747,7 @@ pub const VirtualAllocError = error{Unexpected};
 
 pub fn VirtualAlloc(addr: ?LPVOID, size: usize, alloc_type: DWORD, flProtect: DWORD) VirtualAllocError!LPVOID {
     return kernel32.VirtualAlloc(addr, size, alloc_type, flProtect) orelse {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     };
@@ -1792,7 +1796,7 @@ pub const VirtualQueryError = error{Unexpected};
 pub fn VirtualQuery(lpAddress: ?LPVOID, lpBuffer: PMEMORY_BASIC_INFORMATION, dwLength: SIZE_T) VirtualQueryError!SIZE_T {
     const rc = kernel32.VirtualQuery(lpAddress, lpBuffer, dwLength);
     if (rc == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -1804,7 +1808,7 @@ pub const SetConsoleTextAttributeError = error{Unexpected};
 
 pub fn SetConsoleTextAttribute(hConsoleOutput: HANDLE, wAttributes: WORD) SetConsoleTextAttributeError!void {
     if (kernel32.SetConsoleTextAttribute(hConsoleOutput, wAttributes) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -1817,7 +1821,7 @@ pub fn SetConsoleCtrlHandler(handler_routine: ?HANDLER_ROUTINE, add: bool) !void
     );
 
     if (success == FALSE) {
-        return switch (kernel32.GetLastError()) {
+        return switch (GetLastError()) {
             else => |err| unexpectedError(err),
         };
     }
@@ -1826,7 +1830,7 @@ pub fn SetConsoleCtrlHandler(handler_routine: ?HANDLER_ROUTINE, add: bool) !void
 pub fn SetFileCompletionNotificationModes(handle: HANDLE, flags: UCHAR) !void {
     const success = kernel32.SetFileCompletionNotificationModes(handle, flags);
     if (success == FALSE) {
-        return switch (kernel32.GetLastError()) {
+        return switch (GetLastError()) {
             else => |err| unexpectedError(err),
         };
     }
@@ -1850,7 +1854,7 @@ pub const GetEnvironmentVariableError = error{
 pub fn GetEnvironmentVariableW(lpName: LPWSTR, lpBuffer: [*]u16, nSize: DWORD) GetEnvironmentVariableError!DWORD {
     const rc = kernel32.GetEnvironmentVariableW(lpName, lpBuffer, nSize);
     if (rc == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .ENVVAR_NOT_FOUND => return error.EnvironmentVariableNotFound,
             else => |err| return unexpectedError(err),
         }
@@ -1891,7 +1895,7 @@ pub fn CreateProcessW(
         lpStartupInfo,
         lpProcessInformation,
     ) == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .FILE_NOT_FOUND => return error.FileNotFound,
             .PATH_NOT_FOUND => return error.FileNotFound,
             .ACCESS_DENIED => return error.AccessDenied,
@@ -1934,7 +1938,7 @@ pub const LoadLibraryError = error{
 
 pub fn LoadLibraryW(lpLibFileName: [*:0]const u16) LoadLibraryError!HMODULE {
     return kernel32.LoadLibraryW(lpLibFileName) orelse {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .FILE_NOT_FOUND => return error.FileNotFound,
             .PATH_NOT_FOUND => return error.FileNotFound,
             .MOD_NOT_FOUND => return error.FileNotFound,
@@ -1962,7 +1966,7 @@ pub const LoadLibraryFlags = enum(DWORD) {
 
 pub fn LoadLibraryExW(lpLibFileName: [*:0]const u16, dwFlags: LoadLibraryFlags) LoadLibraryError!HMODULE {
     return kernel32.LoadLibraryExW(lpLibFileName, null, @intFromEnum(dwFlags)) orelse {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             .FILE_NOT_FOUND => return error.FileNotFound,
             .PATH_NOT_FOUND => return error.FileNotFound,
             .MOD_NOT_FOUND => return error.FileNotFound,
@@ -2019,7 +2023,7 @@ pub fn SetFileTime(
 ) SetFileTimeError!void {
     const rc = kernel32.SetFileTime(hFile, lpCreationTime, lpLastAccessTime, lpLastWriteTime);
     if (rc == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -2709,7 +2713,7 @@ fn testNtToWin32Namespace(expected: []const u16, path: []const u16) !void {
 fn getFullPathNameW(path: [*:0]const u16, out: []u16) !usize {
     const result = kernel32.GetFullPathNameW(path, @as(u32, @intCast(out.len)), out.ptr, null);
     if (result == 0) {
-        switch (kernel32.GetLastError()) {
+        switch (GetLastError()) {
             else => |err| return unexpectedError(err),
         }
     }
@@ -4430,7 +4434,8 @@ pub const TEB = extern struct {
     ActiveRpcHandle: PVOID,
     ThreadLocalStoragePointer: PVOID,
     ProcessEnvironmentBlock: *PEB,
-    Reserved2: [399]PVOID,
+    LastErrorValue: ULONG,
+    Reserved2: [399 * @sizeOf(PVOID) - @sizeOf(ULONG)]u8,
     Reserved3: [1952]u8,
     TlsSlots: [64]PVOID,
     Reserved4: [8]u8,
@@ -4450,12 +4455,16 @@ comptime {
         assert(@offsetOf(TEB, "ActiveRpcHandle") == 0x28);
         assert(@offsetOf(TEB, "ThreadLocalStoragePointer") == 0x2C);
         assert(@offsetOf(TEB, "ProcessEnvironmentBlock") == 0x30);
+        assert(@offsetOf(TEB, "LastErrorValue") == 0x34);
+        assert(@offsetOf(TEB, "TlsSlots") == 0xe10);
     } else if (@sizeOf(usize) == 8) {
         assert(@offsetOf(TEB, "EnvironmentPointer") == 0x38);
         assert(@offsetOf(TEB, "ClientId") == 0x40);
         assert(@offsetOf(TEB, "ActiveRpcHandle") == 0x50);
         assert(@offsetOf(TEB, "ThreadLocalStoragePointer") == 0x58);
         assert(@offsetOf(TEB, "ProcessEnvironmentBlock") == 0x60);
+        assert(@offsetOf(TEB, "LastErrorValue") == 0x68);
+        assert(@offsetOf(TEB, "TlsSlots") == 0x1480);
     }
 }
 
lib/std/process/Child.zig
@@ -1358,7 +1358,7 @@ fn windowsMakeAsyncPipe(rd: *?windows.HANDLE, wr: *?windows.HANDLE, sattr: *cons
         sattr,
     );
     if (read_handle == windows.INVALID_HANDLE_VALUE) {
-        switch (windows.kernel32.GetLastError()) {
+        switch (windows.GetLastError()) {
             else => |err| return windows.unexpectedError(err),
         }
     }
@@ -1375,7 +1375,7 @@ fn windowsMakeAsyncPipe(rd: *?windows.HANDLE, wr: *?windows.HANDLE, sattr: *cons
         null,
     );
     if (write_handle == windows.INVALID_HANDLE_VALUE) {
-        switch (windows.kernel32.GetLastError()) {
+        switch (windows.GetLastError()) {
             else => |err| return windows.unexpectedError(err),
         }
     }
@@ -1529,7 +1529,7 @@ fn windowsCmdExePath(allocator: mem.Allocator) error{ OutOfMemory, Unexpected }!
         // TODO: Get the system directory from PEB.ReadOnlyStaticServerData
         const len = windows.kernel32.GetSystemDirectoryW(@ptrCast(unused_slice), @intCast(unused_slice.len));
         if (len == 0) {
-            switch (windows.kernel32.GetLastError()) {
+            switch (windows.GetLastError()) {
                 else => |err| return windows.unexpectedError(err),
             }
         }
lib/std/Thread/Condition.zig
@@ -178,7 +178,7 @@ const WindowsImpl = struct {
 
         // Return error.Timeout if we know the timeout elapsed correctly.
         if (rc == os.windows.FALSE) {
-            assert(os.windows.kernel32.GetLastError() == .TIMEOUT);
+            assert(os.windows.GetLastError() == .TIMEOUT);
             if (!timeout_overflowed) return error.Timeout;
         }
     }
lib/std/debug.zig
@@ -1781,7 +1781,7 @@ pub const DebugInfo = struct {
 
             const handle = windows.kernel32.CreateToolhelp32Snapshot(windows.TH32CS_SNAPMODULE | windows.TH32CS_SNAPMODULE32, 0);
             if (handle == windows.INVALID_HANDLE_VALUE) {
-                switch (windows.kernel32.GetLastError()) {
+                switch (windows.GetLastError()) {
                     else => |err| return windows.unexpectedError(err),
                 }
             }
lib/std/io.zig
@@ -567,7 +567,7 @@ pub fn Poller(comptime StreamEnum: type) type {
                         windows.INFINITE,
                 );
                 if (status == windows.WAIT_FAILED)
-                    return windows.unexpectedError(windows.kernel32.GetLastError());
+                    return windows.unexpectedError(windows.GetLastError());
                 if (status == windows.WAIT_TIMEOUT)
                     return true;
 
@@ -584,7 +584,7 @@ pub fn Poller(comptime StreamEnum: type) type {
                     &self.windows.overlapped[stream_idx],
                     &read_bytes,
                     0,
-                )) switch (windows.kernel32.GetLastError()) {
+                )) switch (windows.GetLastError()) {
                     .BROKEN_PIPE => {
                         self.windows.active.removeAt(active_idx);
                         continue;
@@ -664,7 +664,7 @@ fn windowsAsyncRead(
         const buf = try fifo.writableWithSize(bump_amt);
         var read_bytes: u32 = undefined;
         const read_result = windows.kernel32.ReadFile(handle, buf.ptr, math.cast(u32, buf.len) orelse math.maxInt(u32), &read_bytes, overlapped);
-        if (read_result == 0) return switch (windows.kernel32.GetLastError()) {
+        if (read_result == 0) return switch (windows.GetLastError()) {
             .IO_PENDING => .pending,
             .BROKEN_PIPE => .closed,
             else => |err| windows.unexpectedError(err),
lib/std/os.zig
@@ -61,7 +61,7 @@ pub fn accessW(path: [*:0]const u16) windows.GetFileAttributesError!void {
     if (ret != windows.INVALID_FILE_ATTRIBUTES) {
         return;
     }
-    switch (windows.kernel32.GetLastError()) {
+    switch (windows.GetLastError()) {
         .FILE_NOT_FOUND => return error.FileNotFound,
         .PATH_NOT_FOUND => return error.FileNotFound,
         .ACCESS_DENIED => return error.PermissionDenied,
lib/std/posix.zig
@@ -6912,7 +6912,7 @@ pub fn fsync(fd: fd_t) SyncError!void {
     if (native_os == .windows) {
         if (windows.kernel32.FlushFileBuffers(fd) != 0)
             return;
-        switch (windows.kernel32.GetLastError()) {
+        switch (windows.GetLastError()) {
             .SUCCESS => return,
             .INVALID_HANDLE => unreachable,
             .ACCESS_DENIED => return error.AccessDenied, // a sync was performed but the system couldn't update the access time
lib/std/Thread.zig
@@ -554,7 +554,7 @@ const WindowsThreadImpl = struct {
             0,
             null,
         ) orelse {
-            const errno = windows.kernel32.GetLastError();
+            const errno = windows.GetLastError();
             return windows.unexpectedError(errno);
         };