Commit 82fc360613

Andrew Kelley <andrew@ziglang.org>
2023-04-27 03:20:22
stage2: avoid panicking for unimplemented compiler code
Prevents the compiler from crashing when using `@memset` on extern unions, for example.
1 parent a67dec1
Changed files (2)
src/Sema.zig
@@ -26954,10 +26954,12 @@ fn storePtrVal(
             reinterpret.val_ptr.*.writeToMemory(mut_kit.ty, sema.mod, buffer) catch |err| switch (err) {
                 error.ReinterpretDeclRef => unreachable,
                 error.IllDefinedMemoryLayout => unreachable, // Sema was supposed to emit a compile error already
+                error.Unimplemented => return sema.fail(block, src, "TODO: implement writeToMemory for type '{}'", .{mut_kit.ty.fmt(sema.mod)}),
             };
             operand_val.writeToMemory(operand_ty, sema.mod, buffer[reinterpret.byte_offset..]) catch |err| switch (err) {
                 error.ReinterpretDeclRef => unreachable,
                 error.IllDefinedMemoryLayout => unreachable, // Sema was supposed to emit a compile error already
+                error.Unimplemented => return sema.fail(block, src, "TODO: implement writeToMemory for type '{}'", .{mut_kit.ty.fmt(sema.mod)}),
             };
 
             const arena = mut_kit.beginArena(sema.mod);
@@ -27908,6 +27910,7 @@ fn bitCastVal(
     val.writeToMemory(old_ty, sema.mod, buffer) catch |err| switch (err) {
         error.ReinterpretDeclRef => return null,
         error.IllDefinedMemoryLayout => unreachable, // Sema was supposed to emit a compile error already
+        error.Unimplemented => return sema.fail(block, src, "TODO: implement writeToMemory for type '{}'", .{old_ty.fmt(sema.mod)}),
     };
     return try Value.readFromMemory(new_ty, sema.mod, buffer[buffer_offset..], sema.arena);
 }
src/value.zig
@@ -1281,6 +1281,7 @@ pub const Value = extern union {
     pub fn writeToMemory(val: Value, ty: Type, mod: *Module, buffer: []u8) error{
         ReinterpretDeclRef,
         IllDefinedMemoryLayout,
+        Unimplemented,
     }!void {
         const target = mod.getTarget();
         const endian = target.cpu.arch.endian();
@@ -1370,19 +1371,19 @@ pub const Value = extern union {
             },
             .Union => switch (ty.containerLayout()) {
                 .Auto => return error.IllDefinedMemoryLayout,
-                .Extern => @panic("TODO implement writeToMemory for extern unions"),
+                .Extern => return error.Unimplemented,
                 .Packed => {
                     const byte_count = (@intCast(usize, ty.bitSize(target)) + 7) / 8;
                     return writeToPackedMemory(val, ty, mod, buffer[0..byte_count], 0);
                 },
             },
             .Pointer => {
-                assert(!ty.isSlice()); // No well defined layout.
+                if (ty.isSlice()) return error.IllDefinedMemoryLayout;
                 if (val.isDeclRef()) return error.ReinterpretDeclRef;
                 return val.writeToMemory(Type.usize, mod, buffer);
             },
             .Optional => {
-                assert(ty.isPtrLikeOptional());
+                if (!ty.isPtrLikeOptional()) return error.IllDefinedMemoryLayout;
                 var buf: Type.Payload.ElemType = undefined;
                 const child = ty.optionalChild(&buf);
                 const opt_val = val.optionalValue();
@@ -1392,7 +1393,7 @@ pub const Value = extern union {
                     return writeToMemory(Value.zero, Type.usize, mod, buffer);
                 }
             },
-            else => @panic("TODO implement writeToMemory for more types"),
+            else => return error.Unimplemented,
         }
     }
 
@@ -5401,6 +5402,7 @@ pub const Value = extern union {
             // code late in compilation. So, this error handling is too aggressive and
             // causes some false negatives, causing less-than-ideal code generation.
             error.IllDefinedMemoryLayout => return null,
+            error.Unimplemented => return null,
         };
         const first_byte = byte_buffer[0];
         for (byte_buffer[1..]) |byte| {