Commit 7e2b6b0f1b

Andrew Kelley <andrew@ziglang.org>
2023-09-12 23:19:16
Revert "ci: use zig build check-fmt instead of zig fmt --check"
This reverts commit 4d1432299fe5dccef1e8254800e365c4d6c0d435. Please don't hard-code unrelated concerns this way. build.zig should not have awareness of the naming conventions for cmake build directories.
master
1 parent 5b7eefc
Changed files (5)
ci
aarch64-linux-debug.sh
aarch64-linux-release.sh
x86_64-linux-debug.sh
x86_64-linux-release.sh
build.zig
ci/aarch64-linux-debug.sh
@@ -50,8 +50,11 @@ unset CXX
 
 ninja install
 
+# TODO: move this to a build.zig step (check-fmt)
 echo "Looking for non-conforming code formatting..."
-stage3-debug/bin/zig build check-fmt
+stage3-debug/bin/zig fmt --check .. \
+  --exclude ../test/cases/ \
+  --exclude ../build-debug
 
 # simultaneously test building self-hosted without LLVM and with 32-bit arm
 stage3-debug/bin/zig build \
ci/aarch64-linux-release.sh
@@ -50,8 +50,11 @@ unset CXX
 
 ninja install
 
+# TODO: move this to a build.zig step (check-fmt)
 echo "Looking for non-conforming code formatting..."
-stage3-release/bin/zig build check-fmt
+stage3-release/bin/zig fmt --check .. \
+  --exclude ../test/cases/ \
+  --exclude ../build-release
 
 # simultaneously test building self-hosted without LLVM and with 32-bit arm
 stage3-release/bin/zig build \
ci/x86_64-linux-debug.sh
@@ -50,8 +50,11 @@ unset CXX
 
 ninja install
 
+# TODO: move this to a build.zig step (check-fmt)
 echo "Looking for non-conforming code formatting..."
-stage3-debug/bin/zig build check-fmt
+stage3-debug/bin/zig fmt --check .. \
+  --exclude ../test/cases/ \
+  --exclude ../build-debug
 
 # simultaneously test building self-hosted without LLVM and with 32-bit arm
 stage3-debug/bin/zig build \
ci/x86_64-linux-release.sh
@@ -50,8 +50,12 @@ unset CXX
 
 ninja install
 
+# TODO: move this to a build.zig step (check-fmt)
 echo "Looking for non-conforming code formatting..."
-stage3-release/bin/zig build check-fmt
+stage3-release/bin/zig fmt --check .. \
+  --exclude ../test/cases/ \
+  --exclude ../build-debug \
+  --exclude ../build-release
 
 # simultaneously test building self-hosted without LLVM and with 32-bit arm
 stage3-release/bin/zig build \
build.zig
@@ -422,18 +422,13 @@ pub fn build(b: *std.Build) !void {
     const optimization_modes = chosen_opt_modes_buf[0..chosen_mode_index];
 
     const fmt_include_paths = &.{ "doc", "lib", "src", "test", "tools", "build.zig" };
-    const fmt_exclude_paths = &.{
-        "test/cases",
-        // This is for the CI scripts.
-        "build-debug",
-        "build-release",
-    };
+    const fmt_exclude_paths = &.{"test/cases"};
     const do_fmt = b.addFmt(.{
         .paths = fmt_include_paths,
         .exclude_paths = fmt_exclude_paths,
     });
 
-    b.step("check-fmt", "Check source files having conforming formatting").dependOn(&b.addFmt(.{
+    b.step("test-fmt", "Check source files having conforming formatting").dependOn(&b.addFmt(.{
         .paths = fmt_include_paths,
         .exclude_paths = fmt_exclude_paths,
         .check = true,