Commit `6766528657`

Mitchell Hashimoto <mitchell.hashimoto@gmail.com>

2022-03-19 18:58:33

stage2: fix crash that could happen if `as` zir fails

Example scenario: test { const a: i32 = blk: { if (false) break :blk 24; }; _ = a; } Prior to this, this would panic the compiler with a source needed error. This provides the source as `sema.src`. This is not ideal, since the line it points to is pretty far from the true issue. (One block out) But, this prevents the compiler from straight up crashing and follows a pattern used by similar ZIR which don't provide a src loc.

master

1 parent 69e6d45

Changed files (1)

src

Sema.zig

@@ -6362,7 +6362,7 @@ fn zirAs(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileError!Air.Inst
     defer tracy.end();
 
     const bin_inst = sema.code.instructions.items(.data)[inst].bin;
-    return sema.analyzeAs(block, .unneeded, bin_inst.lhs, bin_inst.rhs);
+    return sema.analyzeAs(block, sema.src, bin_inst.lhs, bin_inst.rhs);
 }
 
 fn zirAsNode(sema: *Sema, block: *Block, inst: Zir.Inst.Index) CompileError!Air.Inst.Ref {

Commit 6766528657

Commit `6766528657`