Commit 660b3e2090

Andrew Kelley <andrew@ziglang.org>
2023-08-25 21:49:01
langref: disable var args example on aarch64-windows
See tracking issues #14096 and #16961. Also, any time a test is skipped it should link to the open bug report for it.
master
1 parent 31ff6e3
Changed files (2)
doc
langref.html.in
test
behavior
var_args.zig
doc/langref.html.in
@@ -11133,9 +11133,14 @@ fn add(count: c_int, ...) callconv(.C) c_int {
 }
 
 test "defining a variadic function" {
-    // Variadic functions are currently disabled on some targets due to miscompilations.
-    if (builtin.cpu.arch == .aarch64 and builtin.os.tag != .windows and builtin.os.tag != .macos) return error.SkipZigTest;
-    if (builtin.cpu.arch == .x86_64 and builtin.os.tag == .windows) return error.SkipZigTest;
+    if (builtin.cpu.arch == .aarch64 and builtin.os.tag != .macos) {
+        // https://github.com/ziglang/zig/issues/14096
+        return error.SkipZigTest;
+    }
+    if (builtin.cpu.arch == .x86_64 and builtin.os.tag == .windows) {
+        // https://github.com/ziglang/zig/issues/16961
+        return error.SkipZigTest;
+    }
 
     try std.testing.expectEqual(@as(c_int, 0), add(0));
     try std.testing.expectEqual(@as(c_int, 1), add(1, @as(c_int, 1)));
test/behavior/var_args.zig
@@ -232,7 +232,10 @@ test "unused VaList arg" {
         // https://github.com/ziglang/zig/issues/14096
         return error.SkipZigTest;
     }
-    if (builtin.cpu.arch == .x86_64 and builtin.os.tag == .windows) return error.SkipZigTest; // TODO
+    if (builtin.cpu.arch == .x86_64 and builtin.os.tag == .windows) {
+        // https://github.com/ziglang/zig/issues/16961
+        return error.SkipZigTest; // TODO
+    }
 
     const S = struct {
         fn thirdArg(dummy: c_int, ...) callconv(.C) c_int {