Commit 4569a28ea3

kcbanner <kcbanner@gmail.com>
2023-03-25 21:33:25
build: fixes from review
1 parent c79073c
Changed files (1)
lib
std
lib/std/Build/CompileStep.zig
@@ -140,7 +140,8 @@ link_function_sections: bool = false,
 /// exported symbols.
 link_gc_sections: ?bool = null,
 
-linker_dynamicbase: ?bool = null,
+/// (Windows) Whether or not to enable ASLR. Maps to the /DYNAMICBASE[:NO] linker argument.
+linker_dynamicbase: bool = true,
 
 linker_allow_shlib_undefined: ?bool = null,
 
@@ -1476,8 +1477,8 @@ fn make(step: *Step, prog_node: *std.Progress.Node) !void {
     if (self.link_gc_sections) |x| {
         try zig_args.append(if (x) "--gc-sections" else "--no-gc-sections");
     }
-    if (self.linker_dynamicbase) |x| {
-        if (!x) try zig_args.append("--no-dynamicbase");
+    if (!self.linker_dynamicbase) {
+        try zig_args.append("--no-dynamicbase");
     }
     if (self.linker_allow_shlib_undefined) |x| {
         try zig_args.append(if (x) "-fallow-shlib-undefined" else "-fno-allow-shlib-undefined");