Commit 43cd9eb110

Suirad <suirad@users.noreply.github.com>
2020-09-26 01:11:31
Add clarification comment
master
1 parent f786524
Changed files (1)
lib
std
os
windows.zig
lib/std/os/windows.zig
@@ -828,7 +828,9 @@ pub fn DeleteFile(sub_path_w: []const u16, options: DeleteFileOptions) DeleteFil
         else => return unexpectedStatus(rc),
     }
 
-    if (options.remove_dir){
+    // If a directory fails to be deleted, CloseHandle will still report success
+    // Check if the directory still exists and return error.DirNotEmpty if true
+    if (options.remove_dir) {
         var basic_info: FILE_BASIC_INFORMATION = undefined;
         switch (ntdll.NtQueryAttributesFile(&attr, &basic_info)) {
             .SUCCESS => return error.DirNotEmpty,