Commit 2f96c55095

Andrew Kelley <andrew@ziglang.org>
2019-04-02 21:29:16
fix cache hash regression
fixes "warning: unexpected seek failure" fix regression introduced by 27e31f04758d95cb7cf51a74e2a3903553ce3bc5 the fd should be closed only if returning with an error
master
1 parent 0cccba7
Changed files (1)
src
cache_hash.cpp
src/cache_hash.cpp
@@ -437,7 +437,9 @@ Error cache_hit(CacheHash *ch, Buf *out_digest) {
                 return ErrorCacheUnavailable;
             }
         }
-        os_file_close(ch->manifest_file);
+        if (return_code != ErrorNone) {
+            os_file_close(ch->manifest_file);
+        }
         return return_code;
     }
     // Cache Hit