Commit `062eb6f3c0`

Luuk de Gram <luuk@degram.dev>

2023-06-18 18:22:04

Compilation: allow threads for Wasm when shared-memory is enabled

When the user enabled the linker-feature 'shared-memory' we do not force a singlethreaded build. The linker already verifies all other CPU features required for threads are enabled. This is true for both WASI and freestanding.

master

1 parent 3819371

Changed files (2)

src

Compilation.zig

target.zig

@@ -1029,7 +1029,7 @@ pub fn create(gpa: Allocator, options: InitOptions) !*Compilation {
 
         const include_compiler_rt = options.want_compiler_rt orelse needs_c_symbols;
 
-        const must_single_thread = target_util.isSingleThreaded(options.target);
+        const must_single_thread = options.target.isWasm() and !options.linker_shared_memory;
         const single_threaded = options.single_threaded orelse must_single_thread;
         if (must_single_thread and !single_threaded) {
             return error.TargetRequiresSingleThreaded;

@@ -207,10 +207,6 @@ pub fn supports_fpic(target: std.Target) bool {
     return target.os.tag != .windows and target.os.tag != .uefi;
 }
 
-pub fn isSingleThreaded(target: std.Target) bool {
-    return target.isWasm();
-}
-
 /// Valgrind supports more, but Zig does not support them yet.
 pub fn hasValgrindSupport(target: std.Target) bool {
     switch (target.cpu.arch) {

Commit 062eb6f3c0

Commit `062eb6f3c0`